Skip to content

Conversation

@pickfire
Copy link

@pickfire pickfire commented Sep 7, 2025

What type of PR is this?

perf

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

去除原子

(Optional) More detailed description for this PR(en: English/zh: Chinese).

Before:

twitter/sonic_rs::from_slice_unchecked
                        time:   [363.26 µs 363.53 µs 363.84 µs]
twitter/sonic_rs::from_slice
                        time:   [386.96 µs 387.34 µs 387.74 µs]
twitter/simd_json::from_slice
                        time:   [493.21 µs 493.61 µs 494.07 µs]
twitter/serde_json::from_slice
                        time:   [1.1023 ms 1.1028 ms 1.1034 ms]
twitter/serde_json::from_str
                        time:   [545.09 µs 545.39 µs 545.76 µs]

citm_catalog/sonic_rs::from_slice_unchecked
                        time:   [629.17 µs 629.67 µs 630.23 µs]
citm_catalog/sonic_rs::from_slice
                        time:   [662.14 µs 662.77 µs 663.50 µs]
citm_catalog/simd_json::from_slice
                        time:   [991.69 µs 992.57 µs 993.58 µs]
citm_catalog/serde_json::from_slice
                        time:   [1.5687 ms 1.5703 ms 1.5719 ms]
citm_catalog/serde_json::from_str
                        time:   [1.2268 ms 1.2275 ms 1.2283 ms]

canada/sonic_rs::from_slice_unchecked
                        time:   [2.4722 ms 2.4735 ms 2.4749 ms]
canada/sonic_rs::from_slice
                        time:   [2.5169 ms 2.5185 ms 2.5201 ms]
canada/simd_json::from_slice
                        time:   [3.1946 ms 3.2023 ms 3.2095 ms]
canada/serde_json::from_slice
                        time:   [5.2201 ms 5.2222 ms 5.2248 ms]
canada/serde_json::from_str
                        time:   [5.2140 ms 5.2157 ms 5.2176 ms]

After:

twitter/sonic_rs::from_slice_unchecked
                        time:   [361.38 µs 361.76 µs 362.30 µs]
twitter/sonic_rs::from_slice
                        time:   [383.33 µs 383.66 µs 384.06 µs]
twitter/simd_json::from_slice
                        time:   [498.60 µs 499.27 µs 500.03 µs]
twitter/serde_json::from_slice
                        time:   [1.0513 ms 1.0518 ms 1.0525 ms]
twitter/serde_json::from_str
                        time:   [534.71 µs 535.03 µs 535.44 µs]

citm_catalog/sonic_rs::from_slice_unchecked
                        time:   [635.39 µs 635.82 µs 636.41 µs]
citm_catalog/sonic_rs::from_slice
                        time:   [667.54 µs 667.97 µs 668.44 µs]
citm_catalog/simd_json::from_slice
                        time:   [981.67 µs 982.59 µs 983.68 µs]
citm_catalog/serde_json::from_slice
                        time:   [1.4641 ms 1.4650 ms 1.4660 ms]
citm_catalog/serde_json::from_str
                        time:   [1.2239 ms 1.2245 ms 1.2252 ms]

canada/sonic_rs::from_slice_unchecked
                        time:   [2.4682 ms 2.4696 ms 2.4712 ms]
canada/sonic_rs::from_slice
                        time:   [2.5145 ms 2.5160 ms 2.5176 ms]
canada/simd_json::from_slice
                        time:   [3.2294 ms 3.2321 ms 3.2350 ms]
canada/serde_json::from_slice
                        time:   [5.2210 ms 5.2229 ms 5.2250 ms]
canada/serde_json::from_str
                        time:   [5.2229 ms 5.2240 ms 5.2253 ms]

Looks similar but I don't think we need the atomic.

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@CLAassistant
Copy link

CLAassistant commented Sep 7, 2025

CLA assistant check
All committers have signed the CLA.

@liuq19
Copy link
Collaborator

liuq19 commented Sep 15, 2025

node should be Send and Sync, and rc make it broken

@liuq19 liuq19 closed this Sep 15, 2025
@pickfire pickfire deleted the remove-atomic branch September 27, 2025 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants