Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #407—list Backblaze S3 contents #408

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

caewok
Copy link

@caewok caewok commented Nov 5, 2021

Fixes #407. Backblaze S3 will return bucket lists without Owner:DisplayName. This causes as.data.frame.s3_bucket to fail when parsing the contents for get_bucket_df. This PR corrects that issue by ensuring that NULL values are changed to NA in the relevant cases.

Please ensure the following before submitting a PR:

  • [ x] if suggesting code changes or improvements, open an issue first
  • [ x] for all but trivial changes (e.g., typo fixes), add your name to DESCRIPTION
  • [ x] for all but trivial changes (e.g., typo fixes), documentation your change in NEWS.md with a parenthetical reference to the issue number being addressed
  • if changing documentation, edit files in /R not /man and run devtools::document() to update documentation
  • add code or new test files to /tests for any new functionality or bug fix
  • [ x] make sure R CMD check runs without error before submitting the PR

Backblaze S3 will return bucket lists without Owner:DisplayName. This causes `as.data.frame.s3_bucket` to fail when parsing the contents for `get_bucket_df`. This PR corrects that issue by ensuring that NULL values are changed to NA in the relevant cases.
Update `as.data.frame` to handle Backblaze S3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws.s3::get_bucket_df does not work with Backblaze S3
1 participant