Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NextMarker instead of tail() to find NextMarker #414

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use NextMarker instead of tail() to find NextMarker #414

wants to merge 2 commits into from

Commits on Mar 31, 2022

  1. Use NextMarker 

    Previously, function erroneously assumed that XML response always had <Content> elements listed last, and merely used `tail()` to get the Key of the last element for use as NextMarker.

This assumption relying on ordering rather than explicitly using element names fails when clients (CEPH S3 interface) return XML that lists metadata fields.  Moreover, the S3 response actually provides a field called NextMarker for this very purpose, which ought to be used instead of attempting to find the last key.

Later, the code again used `tail` erroneously depending on order, rather than merely copying over the NextMarker metadata field onto the expanding concatanated list.
    @cboettig
    cboettig committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    a05623f View commit details
    Browse the repository at this point in the history

  2. update NEWS

    @cboettig
    cboettig committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    c710013 View commit details
    Browse the repository at this point in the history