Merge pull request #7 from MarkEdmondson1234/master

CRAN feedback
cloudyr · Aug 7, 2016 · 3afe4d3 · 3afe4d3
2 parents 18b153f + 92ccb7a
commit 3afe4d3
Show file tree

Hide file tree

Showing 7 changed files with 40 additions and 13 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,16 +1,16 @@
 Package: googleCloudStorageR
 Type: Package
-Version: 0.0.9000
+Version: 0.1.0
 Title: R Interface with Google Cloud Storage
-Description: Interact with Google Cloud Storage API in R.
-Authors@R: c(person("Mark", "Edmondson",email = "m@sunholo.com",
+Description: Interact with Google Cloud Storage API in R. Part of the 'cloudyr' project.
+Authors@R: c(person("Mark", "Edmondson",email = "r@sunholo.com",
                   role = c("aut", "cre")))
-URL: https://github.com/cloudyr/googleCloudStorageR
+URL: http://code.markedmondson.me/googleCloudStorageR/
 BugReports: https://github.com/cloudyr/googleCloudStorageR/issues
 Depends:
     R (>= 3.2.0)
 Imports:
-    googleAuthR (>= 0.2.0.9000),
+    googleAuthR (>= 0.3.1),
     testthat(>= 1.0.2),
     httr (>= 1.2.1),
     jsonlite (>= 1.0)

diff --git a/LICENSE b/LICENSE
@@ -1,2 +1,2 @@
 YEAR: 2016
-COPYRIGHT HOLDER: Mark Edmondson
+COPYRIGHT HOLDER: Sunholo Ltd.
diff --git a/NEWS.md b/NEWS.md
@@ -0,0 +1,6 @@
+# googleCloudStorageR 0.1.0
+
+* Initial release
+
+
+
diff --git a/Readme.md b/Readme.md
@@ -201,7 +201,7 @@ gcs_get_object("your-object", "your-bucket", meta = TRUE)
 
 `googleCloudStorageR` has its own Google project which is used to call the Google Cloud Storage API, but does not have access to the objects or buckets in your Google Project unless you give permission for the library to access your own buckets during the OAuth2 authentication process.  
 
-No other user, including the owner of the Google Cloud Storage API project has access unless you have given them access, but you may want to change to use your own Google Project (that could or could not be the same as the one that holds your buckets) - this is outlined below:
+No other user, including the owner of the Google Cloud Storage API project has access unless you have given them access, but you may want to change to use your own Google Project (that could or could not be the same as the one that holds your buckets).  The instructions below are for when you visit the Google API console (`https://console.developers.google.com/apis/`)
 
 ### For local use
 

diff --git a/cran-comments.md b/cran-comments.md
@@ -0,0 +1,21 @@
+## Test environments
+* local OS X install, R 3.3.0
+* ubuntu 12.04 (on travis-ci), R 3.3.0
+* win-builder (devel and release)
+
+## R CMD check results
+
+0 errors | 0 warnings | 2 notes
+
+* This is a new release.
+
+Possibly mis-spelled words in DESCRIPTION:
+  API (5:49)
+
+* API is spelt correctly
+
+## Reverse dependencies
+
+This is a new release, so there are no reverse dependencies.
+
+---
diff --git a/vignettes/googleCloudStorageR.Rmd b/vignettes/googleCloudStorageR.Rmd
@@ -15,7 +15,7 @@ R library for interacting with the Google Cloud Storage JSON API ([api docs](htt
 
 Google Cloud Storage charges you for storage [(prices here)](https://cloud.google.com/storage/pricing).
 
-You can use your own Google Project with a credit card added to create buckets, where the charges will apply.  This can be done in the [Google API Console](https://console.developers.google.com)
+You can use your own Google Project with a credit card added to create buckets, where the charges will apply.  This can be done in the Google API Console after login here: `https://console.developers.google.com`.
 
 ## Examples
 
@@ -127,7 +127,7 @@ download_url
 
 ## Uploading via a Shiny app
 
-The library is also compatible with Shiny authentication flows, so you can create Shiny apps that lets users log in and download their own data.  
+The library is also compatible with Shiny authentication flows, so for example you can create Shiny apps that lets users log in and upload their own data.  
 
 An example of that is shown below:
 
@@ -210,7 +210,7 @@ gcs_get_object("your-object", "your-bucket", meta = TRUE)
 
 `googleCloudStorageR` has its own Google project which is used to call the Google Cloud Storage API, but does not have access to the objects or buckets in your Google Project unless you give permission for the library to access your own buckets during the OAuth2 authentication process.  
 
-No other user, including the owner of the Google Cloud Storage API project has access unless you have given them access, but you may want to change to use your own Google Project (that could or could not be the same as the one that holds your buckets) - this is outlined below:
+No other user, including the owner of the Google Cloud Storage API project has access unless you have given them access, but you may want to change to use your own Google Project (that could or could not be the same as the one that holds your buckets).  The instructions below are for when you visit the Google API console (`https://console.developers.google.com/apis/`)
 
 ### For local use
 

diff --git a/vignettes/googleCloudStorageR.html b/vignettes/googleCloudStorageR.html
@@ -78,7 +78,7 @@ <h4 class="date"><em>2016-08-07</em></h4>
 <div id="setup" class="section level2">
 <h2>Setup</h2>
 <p>Google Cloud Storage charges you for storage <a href="https://cloud.google.com/storage/pricing">(prices here)</a>.</p>
-<p>You can use your own Google Project with a credit card added to create buckets, where the charges will apply. This can be done in the <a href="https://console.developers.google.com">Google API Console</a></p>
+<p>You can use your own Google Project with a credit card added to create buckets, where the charges will apply. This can be done in the Google API Console after login here: <code>https://console.developers.google.com</code>.</p>
 </div>
 <div id="examples" class="section level2">
 <h2>Examples</h2>
@@ -175,7 +175,7 @@ <h3>Creating download links</h3>
 </div>
 <div id="uploading-via-a-shiny-app" class="section level2">
 <h2>Uploading via a Shiny app</h2>
-<p>The library is also compatible with Shiny authentication flows, so you can create Shiny apps that lets users log in and download their own data.</p>
+<p>The library is also compatible with Shiny authentication flows, so for example you can create Shiny apps that lets users log in and upload their own data.</p>
 <p>An example of that is shown below:</p>
 <div class="sourceCode"><pre class="sourceCode r"><code class="sourceCode r"><span class="kw">library</span>(<span class="st">&quot;shiny&quot;</span>)
 <span class="kw">library</span>(<span class="st">&quot;googleAuthR&quot;</span>)
@@ -251,7 +251,7 @@ <h2>Object administration</h2>
 <div id="explanation-of-google-project-access" class="section level2">
 <h2>Explanation of Google Project access</h2>
 <p><code>googleCloudStorageR</code> has its own Google project which is used to call the Google Cloud Storage API, but does not have access to the objects or buckets in your Google Project unless you give permission for the library to access your own buckets during the OAuth2 authentication process.</p>
-<p>No other user, including the owner of the Google Cloud Storage API project has access unless you have given them access, but you may want to change to use your own Google Project (that could or could not be the same as the one that holds your buckets) - this is outlined below:</p>
+<p>No other user, including the owner of the Google Cloud Storage API project has access unless you have given them access, but you may want to change to use your own Google Project (that could or could not be the same as the one that holds your buckets). The instructions below are for when you visit the Google API console (<code>https://console.developers.google.com/apis/</code>)</p>
 <div id="for-local-use" class="section level3">
 <h3>For local use</h3>
 <ol style="list-style-type: decimal">