Feat/text formatter #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to easily handle optionnal parameters
quite redundant as for now the discussion's title is not shown yet ^^
only when available in the store, for now
This currently relies on a hack while the following issue is open: <flarum/framework#3720>
n-peugnet
force-pushed
the
feat/text-formatter
branch
from
c6cb1b3
to
75e4a65
Compare
This way we don't need to parse the message again, and the regex is only written once. This also make short references create back references. And this is a lot cleaner, this goes without saying.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4
Still missing:
#<id>linksI really don't know how to do the last two ones as TextFormatter js filters are run synchronously while the store interface is asynchronous.