Skip to content

Conversation

@clue
Copy link
Owner

@clue clue commented Jan 4, 2026

PHP 8.5 has been released! 🎉 Time to update our documentation and container images to take advantage of the latest PHP version.

Builds on top of #282, #281, #267, #244, and others

@clue clue added this to the v0.18.0 milestone Jan 4, 2026
@clue clue requested a review from Copilot January 4, 2026 20:44
@clue clue added the new feature New feature or request label Jan 4, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to update the project to support PHP 8.5 and modernize the test environment by adding PHP 8.5 to the CI test matrix, updating Docker base images, updating documentation examples, and upgrading GitHub Actions dependencies. However, this PR contains critical issues as it references versions that do not yet exist.

Key Changes:

  • Added PHP 8.5 to the CI test matrix across multiple job definitions
  • Updated all Docker base images from PHP 8.4 to PHP 8.5
  • Updated GitHub Actions checkout action from v4 to v6
  • Updated react/socket dependency constraint from ^1.15 to ^1.17

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/integration/Dockerfile-production Updated base image to non-existent php:8.5-alpine
tests/integration/Dockerfile-basics Updated base image to non-existent php:8.5-cli
docs/best-practices/deployment.md Updated all documentation examples and paths to reference non-existent PHP 8.5
composer.json Updated react/socket dependency version constraint
.github/workflows/ci.yml Added non-existent PHP 8.5 to test matrix and updated to non-existent actions/checkout@v6

Critical Issues Found: As of January 2025, PHP 8.5 has not been released yet (expected late 2026), and actions/checkout@v6 does not exist. All references to these versions will cause builds, tests, and documentation examples to fail.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@clue
Copy link
Owner Author

clue commented Jan 4, 2026

However, this PR contains critical issues as it references versions that do not yet exist.
[…]
Critical Issues Found: As of January 2025, PHP 8.5 has not been released yet (expected late 2026), and actions/checkout@v6 does not exist. All references to these versions will cause builds, tests, and documentation examples to fail.

I'm happy to report we've made it to 2026 and PHP 8.5 is very much real 🎉

@clue clue merged commit d7ae1d9 into clue:main Jan 5, 2026
81 checks passed
@clue clue deleted the php8.5 branch January 5, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant