Socket: make m_address and m_remoteEndpoint members non-const.

This avoids needing const_cast conversions when modifying them, which is actually undefined behavior in C++ because we were modifying a const object.
cmangos · Sep 27, 2023 · 70e1611 · 70e1611
1 parent 3f60957
commit 70e1611
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/shared/Network/Socket.cpp b/src/shared/Network/Socket.cpp
@@ -41,8 +41,8 @@ namespace MaNGOS
     {
         try
         {
-            const_cast<std::string&>(m_address) = m_socket.remote_endpoint().address().to_string();
-            const_cast<std::string&>(m_remoteEndpoint) = boost::lexical_cast<std::string>(m_socket.remote_endpoint());
+            m_address = m_socket.remote_endpoint().address().to_string();
+            m_remoteEndpoint = boost::lexical_cast<std::string>(m_socket.remote_endpoint());
             m_remoteAddress = m_socket.remote_endpoint().address();
             m_remotePort = m_socket.remote_endpoint().port();
         }

diff --git a/src/shared/Network/Socket.hpp b/src/shared/Network/Socket.hpp
@@ -77,8 +77,8 @@ namespace MaNGOS
             void OnError(const boost::system::error_code &error);
 
         protected:
-            const std::string m_address;
-            const std::string m_remoteEndpoint;
+            std::string m_address;
+            std::string m_remoteEndpoint;
             boost::asio::ip::address m_remoteAddress;
             uint16 m_remotePort;