Cleanup: Add missing c_str() calls and missing virtual destructor for…

… PricingStrategy (#140)
cmangos · Feb 2, 2025 · 4d949fe · 4d949fe
1 parent 2c2e477
commit 4d949fe
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/ahbot/PricingStrategy.h b/ahbot/PricingStrategy.h
@@ -10,6 +10,7 @@ namespace ahbot
     {
     public:
         PricingStrategy(Category* category) : category(category) {}
+        virtual ~PricingStrategy() {}
 
     public:
         virtual uint32 GetSellPrice(ItemPrototype const* proto, uint32 auctionHouse, bool ignoreMarket = false, std::ostringstream *explain = NULL);

diff --git a/playerbot/RandomPlayerbotMgr.cpp b/playerbot/RandomPlayerbotMgr.cpp
@@ -862,7 +862,7 @@ bool RandomPlayerbotMgr::AddNamedLocation(std::string const& name, WorldLocation
 {
     if (namedLocations.find(name) != namedLocations.end())
     {
-        sLog.outError("RandomPlayerbotMgr::AddNamedLocation: Failed to add named location '%s' - already exists!", name);
+        sLog.outError("RandomPlayerbotMgr::AddNamedLocation: Failed to add named location '%s' - already exists!", name.c_str());
         return false;
     }
 
@@ -876,7 +876,7 @@ bool RandomPlayerbotMgr::GetNamedLocation(std::string const& name, WorldLocation
     auto itr = namedLocations.find(name);
     if (itr == namedLocations.end())
     {
-        sLog.outError("RandomPlayerbotMgr::GetNamedLocation: Named location '%s' not found! Please ensure that your ai_playerbot_named_location table is up to date.", name);
+        sLog.outError("RandomPlayerbotMgr::GetNamedLocation: Named location '%s' not found! Please ensure that your ai_playerbot_named_location table is up to date.", name.c_str());
         return false;
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -10,6 +10,7 @@ namespace ahbot @@
         {
         public:
             PricingStrategy(Category* category) : category(category) {}
+            virtual ~PricingStrategy() {}
         public:
             virtual uint32 GetSellPrice(ItemPrototype const* proto, uint32 auctionHouse, bool ignoreMarket = false, std::ostringstream *explain = NULL);
@@ Expand Down @@