Change roll to greed for inappropriate items

Change only applies to bots with real player master
Config is added to restore old behavior

Author: celguar

playerbot/PlayerbotAIConfig.cpp

@@ -162,6 +162,7 @@ bool PlayerbotAIConfig::Initialize()
     randomGearProgression = config.GetBoolDefault("AiPlayerbot.RandomGearProgression", true);
     randomGearLoweringChance = config.GetFloatDefault("AiPlayerbot.RandomGearLoweringChance", 0.15f);
     randomBotMaxLevelChance = config.GetFloatDefault("AiPlayerbot.RandomBotMaxLevelChance", 0.15f);
+    rollBadItemsWithPlayer = config.GetBoolDefault("AiPlayerbot.RollBadItemsWithPlayer", false);
     randomBotRpgChance = config.GetFloatDefault("AiPlayerbot.RandomBotRpgChance", 0.35f);
     usePotionChance = config.GetFloatDefault("AiPlayerbot.UsePotionChance", 1.0f);
     attackEmoteChance = config.GetFloatDefault("AiPlayerbot.AttackEmoteChance", 0.0f);

playerbot/PlayerbotAIConfig.h

@@ -153,6 +153,7 @@ class PlayerbotAIConfig
     std::list<uint32> randomGearWhitelist;
     bool randomGearProgression;
     float randomGearLoweringChance;
+    bool rollBadItemsWithPlayer;
     float randomBotMaxLevelChance;
     float randomBotRpgChance;
     float usePotionChance;

playerbot/aiplayerbot.conf.dist.in

@@ -128,6 +128,12 @@ AiPlayerbot.RandomGearTabardsUnobtainable = 0
 # List of item IDs to exclude from random gear, separated by comma
 AiPlayerbot.RandomGearBlacklist = 0
 
+# Roll need on items if slot is empty or broken, even if not appropriate for bot's spec
+# Bots without real player master ignore this config and always roll need in that case
+# 1 - roll need on such items
+# 0 - roll greed on such items (Default)
+AiPlayerbot.RollBadItemsWithPlayer = 0
+
 # Chance random bot has max level on first randomize (default 0.15)
 AiPlayerbot.RandomBotMaxLevelChance = 0.15
 

playerbot/aiplayerbot.conf.dist.in.tbc

@@ -132,6 +132,12 @@ AiPlayerbot.RandomGearTabardsUnobtainable = 0
 # List of item IDs to exclude from random gear, separated by comma
 AiPlayerbot.RandomGearBlacklist = 0
 
+# Roll need on items if slot is empty or broken, even if not appropriate for bot's spec
+# Bots without real player master ignore this config and always roll need in that case
+# 1 - roll need on such items
+# 0 - roll greed on such items (Default)
+AiPlayerbot.RollBadItemsWithPlayer = 0
+
 # Chance random bot has max level on first randomize (default 0.15)
 AiPlayerbot.RandomBotMaxLevelChance = 0.15
 

playerbot/aiplayerbot.conf.dist.in.wotlk

@@ -135,6 +135,12 @@ AiPlayerbot.RandomGearTabardsUnobtainable = 0
 # List of item IDs to exclude from random gear, separated by comma
 AiPlayerbot.RandomGearBlacklist = 0
 
+# Roll need on items if slot is empty or broken, even if not appropriate for bot's spec
+# Bots without real player master ignore this config and always roll need in that case
+# 1 - roll need on such items
+# 0 - roll greed on such items (Default)
+AiPlayerbot.RollBadItemsWithPlayer = 0
+
 # Chance random bot has max level on first randomize (default 0.15)
 AiPlayerbot.RandomBotMaxLevelChance = 0.15
 

playerbot/strategy/actions/LootRollAction.cpp

@@ -186,7 +186,6 @@ RollVote RollAction::CalculateRollVote(ItemQualifier& itemQualifier)
     case ItemUsage::ITEM_USAGE_EQUIP:
     case ItemUsage::ITEM_USAGE_GUILD_TASK:
     case ItemUsage::ITEM_USAGE_FORCE_NEED:
-    case ItemUsage::ITEM_USAGE_BAD_EQUIP:
         needVote = ROLL_NEED;
         break;
     case ItemUsage::ITEM_USAGE_SKILL:
@@ -206,6 +205,16 @@ RollVote RollAction::CalculateRollVote(ItemQualifier& itemQualifier)
         break;
     }
 
+    // special case for bad equip
+    if (usage == ItemUsage::ITEM_USAGE_BAD_EQUIP)
+    {
+        bool shouldEquipBadItems = sPlayerbotAIConfig.rollBadItemsWithPlayer || !ai->HasRealPlayerMaster();
+        if (shouldEquipBadItems)
+            needVote == ROLL_NEED;
+        else
+            needVote = ROLL_GREED;
+    }
+
     bool canLoot = StoreLootAction::IsLootAllowed(itemQualifier, bot->GetPlayerbotAI());
 
     if (AI_VALUE2(bool, "manual bool", "roll feedback"))