Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Love is in the Air fixes #1303

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Love is in the Air fixes #1303

wants to merge 9 commits into from

Conversation

RazzorX
Copy link
Collaborator

@RazzorX RazzorX commented Feb 11, 2024

  • Texts and Quest assignment fixes
  • added missing Objects and Npcs
  • added all spawns to event 8

My first attempt to create something on this scale. So, bear with me. :)

(Feb 25 2024)
That's all for now. I'll open a new PR for further event fixes. (mostly quest stuff, if I can do that)

For a better structure to work with, I would like to have all the spawns in the main database.
So only if the PR is accepted, of course. :)

@RazzorX
Copy link
Collaborator Author

RazzorX commented Feb 11, 2024

This whole event needs a lot of love. There are missings spawns (alot) and broken quests. I will write a bug report with more information.
Edit: here it is #1304

- added a few more texts
@al3xc1985
Copy link
Contributor

If u need anyinfo about this tell me so I can sniff from offi. Make me a list as fast as possible and I will take all the data u need

@RazzorX
Copy link
Collaborator Author

RazzorX commented Feb 16, 2024

Thank's for the offer. Please take a look at the issues report here: #1304. These are the things that would be necessary to start with.

I would also be interested in a sniffer / parser for the current WotLK classic! I have some ideas about what data I could collect with it.

@heyitsbench
Copy link

heyitsbench commented Feb 16, 2024

I would also be interested in a sniffer / parser for the current WotLK classic!

heyitsbench on Discord if you'd like, I've gotten a fair bit of decor/creatures sniffed on Wrath Classic.

EDIT: Misunderstood, my mistake. 😛

@miraco
Copy link
Contributor

miraco commented Feb 16, 2024

https://github.com/TrinityCore/ymir/releases

@al3xc1985
Copy link
Contributor

I will do a sniff and video and post in on youtube, u will have a link with them

Is that ok?

@RazzorX
Copy link
Collaborator Author

RazzorX commented Feb 18, 2024

Yes, that would be ok for me. Thank you very much.

@al3xc1985
Copy link
Contributor

I reported them on the issue

U have all u asked for
Also if there is anything else to track tell me, or u don't understand something, I can help out

U also have boats quests, mobs, gossips, emotes

@RazzorX RazzorX marked this pull request as draft February 21, 2024 13:06
@RazzorX
Copy link
Collaborator Author

RazzorX commented Feb 21, 2024

- From now on I will write my questions here. When a question has been answered I will remove it. To keep things lucid.

@Grz3s I need a guid for creatures and one for gameobjects where i can put the spawns in. I don't want everything to get messed up. Thanks

@Grz3s
Copy link
Member

Grz3s commented Feb 21, 2024

spell_script_target - goes directly into DB...
look here -->
2bdb849#diff-f59b796189f25c276d4d83ce6010f5a3d39b89d89970c18787ee59a482082368R15

- added more missing spawns (data taken from TC)
- added missing Crown mobs and their creature_addon stuff
- assign all spawns to event
@Grz3s
Copy link
Member

Grz3s commented Feb 28, 2024

(...) I need a guid for creatures and one for gameobjects where i can put the spawns in. I don't want everything to get messed up. Thanks (...)
PLS use smth that is not used by any of 3 DBs (classic, tdb and wotlk)
if not let me know how many guids you need .. ill find smth free

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants