Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix provisioning imports in tf tools. #13

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Fix provisioning imports in tf tools. #13

merged 1 commit into from
Feb 16, 2024

Conversation

riga
Copy link
Member

@riga riga commented Feb 16, 2024

This PR fixes some imports in the tensorflow tools.

Last time, we forgot to expose the deprecated load_graph and save_graph functions (that we renamed to load_frozen_graph and save_frozen_graph, respectively). This currently results in, e.g.,

cmsml.tensorflow.save_graph(...)

not being accessible at all whereas we just wanted to deprecate them. This "hard cut" could lead to some complications downstream.

For consistency, a new release could be necessary.

@riga riga added the improvement Improvement of existing functionality label Feb 16, 2024
@riga riga requested a review from valsdav February 16, 2024 08:06
@valsdav valsdav merged commit bcfc68d into master Feb 16, 2024
11 checks passed
@riga riga deleted the fix_tf_imports branch February 16, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants