Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set TMPDIR in docker_launcher.sh if not set already #2377

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Set TMPDIR in docker_launcher.sh if not set already #2377

merged 1 commit into from
Nov 18, 2024

Conversation

iarspider
Copy link
Contributor

This should fix Risc-V builds. @smuzaffar as discussed.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 18, 2024 •
edited
Loading

cms-bot internal usage

@iarspider
Copy link
Contributor Author

please test

@smuzaffar
Copy link
Contributor

externals

docker_launcher.sh did not fail, so changes should be fine for non-riscv64. In order to test it properly, we need to get the riscv64 IB.

@smuzaffar smuzaffar merged commit 69d539d into master Nov 18, 2024
6 of 9 checks passed
@iarspider iarspider deleted the set-tmpdir branch November 18, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
externals-pending orp-pending pending-signatures tests-started
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iarspider @cmsbuild @smuzaffar