Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ROCm 6.x (14.0.x) #46455

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Oct 20, 2024

PR description:

ROCm 6.0 moved rocm_version.h to rocm-core/rocm_version.h.

This change is useful for testing the impact of more recent ROCm versions on the HLT performance.

PR validation:

Tested on AMD MI300X GPUs with ROCm 6.2.2.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #44824.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 20, 2024

A new Pull Request was created by @fwyzard for CMSSW_14_0_X.

It involves the following packages:

  • HeterogeneousCore/ROCmServices (heterogeneous)

@cmsbuild, @fwyzard, @makortel can you please review it and eventually sign? Thanks.
@makortel, @missirol, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 20, 2024

cms-bot internal usage

@fwyzard fwyzard changed the title Update HeterogeneousCore/ROCmServices/plugins/ROCmService.cc Add support for ROCm 6.x (14.0.x) Oct 20, 2024
@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 20, 2024

backport #44824

@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 20, 2024

enable gpu

@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 20, 2024

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Oct 20, 2024

+heterogeneous

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf7f9e/42314/summary.html
COMMIT: 8021b14
CMSSW: CMSSW_14_0_X_2024-10-20-0000/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46455/42314/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 24 differences found in the comparisons
  • DQMHistoTests: Total files compared: 7
  • DQMHistoTests: Total histograms compared: 53015
  • DQMHistoTests: Total failures: 688
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 52327
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
  • Checked 24 log files, 30 edm output root files, 7 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 39c747b into cms-sw:CMSSW_14_0_X Oct 29, 2024
12 checks passed
@fwyzard fwyzard deleted the Support_ROCm60_140x branch November 13, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants