build+ci: make local, gh, and Jenkins envs identical #2019
+48
−52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An attempt to get our Python environments consistent across: local, Github CI, and Jenkins builds.
Changelog
make venv
did not upgrade pip. Jenkins pinned pip to 23.0.1. To make this consistent, CI now callsmake venv
andmake venv
installs pip==23.0.1.make install
.pylint
andpytest
were already listed in every indicator'ssetup.py
andpydocstyle
was haphardly listed, so I removed the install command from CI, and addedpydocstyle
to the rest of the indicators.pip install numpy
command since each indicator either explicitly lists it as a dependency or transitively through Pandas, so I removed that line.Associated Issue(s)