Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build+ci: make local, gh, and Jenkins envs identical #2019

Open
wants to merge 1 commit into
base: 1973-clean-up-delphi-utils-take-2
Choose a base branch
from

Conversation

dshemetov
Copy link
Contributor

@dshemetov dshemetov commented Aug 9, 2024

Description

An attempt to get our Python environments consistent across: local, Github CI, and Jenkins builds.

Changelog

  • CI would just upgrade pip to the latest sometimes. make venv did not upgrade pip. Jenkins pinned pip to 23.0.1. To make this consistent, CI now calls make venv and make venv installs pip==23.0.1.
  • CI installed pydocstyle pylint pytest separately from calling make install. pylint and pytest were already listed in every indicator's setup.py and pydocstyle was haphardly listed, so I removed the install command from CI, and added pydocstyle to the rest of the indicators.
  • Jenkins had an unnecessary pip install numpy command since each indicator either explicitly lists it as a dependency or transitively through Pandas, so I removed that line.
  • twine and build are needed to build and publish _delphi_utils and were only installed in the release CI. Added that to the [dev] section of _delphi_utils dependencies instead and removed the CI-specific line.
  • wheel had a separate install in many places, but we only need it for the bdist_wheel command, which setuptools>=70.1 provides (see historical note), so I removed it and added the setuptools>=70.1 version requirement to _delphi_utils build environment.

Associated Issue(s)

@dshemetov dshemetov changed the base branch from 1973-clean-up-delphi-utils-take-2 to main August 9, 2024 17:05
* pin pip==23.0.1 everywhere
* remove pip install calls from ci and deploy,
  make sure all dependencies are listed in
  pyproject.toml or setup.py and installed by the
  Makefile
* remove wheel from dependencies, only needed
  wheel for bdist_wheel command, which
  setuptools>=70.1 provides
@dshemetov dshemetov changed the base branch from main to 1973-clean-up-delphi-utils-take-2 August 9, 2024 18:03
@dshemetov dshemetov changed the title build+ci: make dev envs identical with gh build envs build+ci: make local, gh, and Jenkins envs identical Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant