-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NSSP secondary source #2074
Open
minhkhul
wants to merge
17
commits into
main
Choose a base branch
from
nssp_secondary_source
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
7e2229a
base changes
minhkhul 6325e09
lint
minhkhul 99779c3
lint
minhkhul 767b97e
add test
minhkhul bb6c566
fix hhs bug + doc to readme + fix signal grouping
minhkhul 188c2f4
fix weird nan
minhkhul 21d9732
logging + error details
minhkhul 852f6d9
test data sync
minhkhul 2e703e7
Merge branch 'main' into nssp_secondary_source
minhkhul a8e5c89
typo in pull.py
minhkhul bbe135b
region to lower
minhkhul b9df78f
add log
minhkhul ae5d623
fix str bug
minhkhul 9e95adb
add backup data mechanism
minhkhul 9feccef
adjust details.md
minhkhul e89a299
appease linter
minhkhul f3cb509
add tests for secondary source backup
minhkhul File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minhkhul marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aysim319 marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
[ | ||
{ | ||
"week_end": "2022-10-01T00:00:00.000", | ||
"pathogen": "COVID-19", "geography": "National", | ||
"percent_visits": "1.8", | ||
"status": "Reporting", | ||
"trend_on_date": "Decreasing", | ||
"recent_trend": "Decreasing" | ||
}, | ||
{ | ||
"week_end": "2022-10-01T00:00:00.000", | ||
"pathogen": "Influenza", | ||
"geography": "National", | ||
"percent_visits": "0.5", | ||
"status": "Reporting", | ||
"trend_on_date": "Increasing", | ||
"recent_trend": "Increasing" | ||
}, | ||
{ | ||
"week_end": "2022-10-01T00:00:00.000", | ||
"pathogen": "RSV", | ||
"geography": "National", | ||
"percent_visits": "0.5", | ||
"status": "Reporting", | ||
"trend_on_date": "Increasing", | ||
"recent_trend": "Increasing" | ||
}, | ||
{ | ||
"week_end": "2022-10-01T00:00:00.000", | ||
"pathogen": "Combined", | ||
"geography": "National", | ||
"percent_visits": "2.8", | ||
"status": "Reporting", | ||
"trend_on_date": "Decreasing", | ||
"recent_trend": "Decreasing" | ||
}, | ||
{ | ||
"week_end": "2022-10-15T00:00:00.000", | ||
"pathogen": "COVID-19", | ||
"geography": "National", | ||
"percent_visits": "1.6", | ||
"status": "Reporting", | ||
"trend_on_date": "Decreasing", | ||
"recent_trend": "Decreasing" | ||
}, | ||
{ | ||
"week_end": "2022-10-15T00:00:00.000", | ||
"pathogen": "Influenza", | ||
"geography": "National", | ||
"percent_visits": "0.9", | ||
"status": "Reporting", | ||
"trend_on_date": "Increasing", | ||
"recent_trend": "Increasing" | ||
}, | ||
{ | ||
"week_end": "2022-10-15T00:00:00.000", | ||
"pathogen": "RSV", | ||
"geography": "National", | ||
"percent_visits": "0.7", | ||
"status": "Reporting", | ||
"trend_on_date": "Increasing", | ||
"recent_trend": "Increasing" | ||
}, | ||
{ | ||
"week_end": "2022-10-15T00:00:00.000", | ||
"pathogen": "Combined", | ||
"geography": "National", | ||
"percent_visits": "3.2", | ||
"status": "Reporting", | ||
"trend_on_date": "Increasing", | ||
"recent_trend": "Decreasing" | ||
} | ||
] |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mention that there are some difference that's significant; I actually got 4% of the data having more that .1 difference and I would also mention this to logan/daniel/etc as an fyi
specifically for hhs region 7 seems to be the least similar... at least in this run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea it's expected that hhs got wilder differences since the primary source signal values at hhs geo-level were 1. aggregated from state level data 2. using 2020 population weights, rather than something directly published by the source like the equivalent secondary signals for hhs geos. The public facing docs mentions this weighing already, but I'll update it and link stuff here with more info after the pipeline is in a good spot.