Skip to content

Conversation

@krichter722
Copy link
Contributor

because otherwise the script doesn't detect failure of delegate scripts (e.g. failure of vice-setup-user called in vice-setup causes weird result/feedback)

…t failure of delegate scripts (e.g. failure of vice-setup-user called in vice-setup causes weird result/feedback)
@jaharkes
Copy link
Member

I'm slightly hesitant applying this because I'm afraid we might call some command that is in some cases allowed to fail, and should be converted to cmd || true when we run with -e.

@krichter722
Copy link
Contributor Author

I'm slightly hesitant applying this because I'm afraid we might call some command that is in some cases allowed to fail, and should be converted to cmd || true when we run with -e.

I agree. The question is whether it's worth thinking about migrating scripts to python since I hate the aspect of (failing) command handling and the absense of exceptions in bash - I don't want to become a coda developer - per se ;) -, but I don't like the idea of others suffering.

@jaharkes
Copy link
Member

Yes, i think something as failure prone as vice-setup is an excellent candidate to be rewritten in python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants