Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "status" command #62

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Add "status" command #62

merged 1 commit into from
Nov 14, 2024

Conversation

SchoolGuy
Copy link
Member

@SchoolGuy SchoolGuy commented Nov 14, 2024

Fixes #61

This outputs the server-side generated output in text mode.

Edit: There is a backend bug that I need to report which causes the generation to fail if logrotate compressed files with xz. This issue is visible in the CLI but not fixable on the CLI side.

@SchoolGuy SchoolGuy added this to the V0.0.1 milestone Nov 14, 2024
@SchoolGuy SchoolGuy requested a review from a team November 14, 2024 09:38
Copy link

@tiltingpenguin tiltingpenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there not be an option to call the status with normal mode?

cmd/status_test.go Show resolved Hide resolved
@SchoolGuy
Copy link
Member Author

Nope we don't need "normal" mode as we would need to somehow give the user an option to give a custom format which wasn't offered by the old CLI. In the future we might offer JSON output but that is a future task IMHO.

@SchoolGuy SchoolGuy merged commit d317eef into main Nov 14, 2024
20 checks passed
@SchoolGuy SchoolGuy deleted the feature/add-status branch November 14, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add cobbler status command
2 participants