Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added new blog post, corresponding images, and a new config file #186

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

added new blog post, corresponding images, and a new config file #186

wants to merge 4 commits into from
+646 −0

Conversation

sus-admin
Copy link

No description provided.

@sus-admin sus-admin mentioned this pull request Nov 13, 2024
Open
SchoolGuy
SchoolGuy approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking comments. Just a few pointers that you might want to update. If not, give me a ping and I merge this PR. If you want to adjust the PR I will gladly re-review the article. Thanks for the contribution!

_includes/figure.liquid Show resolved Hide resolved
@sus-admin
Copy link
Author

I will get the PR updated as you described. Should be ready by tomorrow.

@SchoolGuy
Copy link
Member

@sus-admin If you want I would merge this. Or do you want to patch up anything before we merge this PR?

@sus-admin
Copy link
Author

@SchoolGuy go ahead and merge, thanks. I will start working on some PRs for my other guides, I'm very interested in your feedback and how I can help get some more fixes included in a future release.

@SchoolGuy
Copy link
Member

@sus-admin First feedback is an oversight of mine during the review. I do desire that all commits are signed via GPG. Is that something you can do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchoolGuy SchoolGuy SchoolGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sus-admin @SchoolGuy