Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load built-in signatures #76

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Load built-in signatures #76

merged 1 commit into from
Apr 19, 2024

Conversation

quinilo
Copy link
Contributor

@quinilo quinilo commented Apr 17, 2024 •
edited by SchoolGuy
Loading

Fixes #73

@SchoolGuy SchoolGuy self-requested a review April 17, 2024 09:47
@SchoolGuy SchoolGuy added this to the v0.2.0 milestone Apr 17, 2024
SchoolGuy
SchoolGuy requested changes Apr 17, 2024
View reviewed changes
Copy link
Member

@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this PR is a very good starting point but it needs some work to be mergable. Thank you for tackling this!

P.S.: Please don't forget to add a changelog fragment (73.added).

libcobblersignatures/enums.py Outdated Show resolved Hide resolved
libcobblersignatures/__init__.py Outdated Show resolved Hide resolved
libcobblersignatures/__init__.py Outdated Show resolved Hide resolved
@quinilo quinilo force-pushed the build-in-update branch 2 times, most recently from a6d56ce to 814885e Compare April 19, 2024 07:44
@SchoolGuy SchoolGuy changed the title Build in update Load built-in signatures Apr 19, 2024
SchoolGuy
SchoolGuy approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@SchoolGuy SchoolGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your help with this issue! This code now looks much better.

@SchoolGuy SchoolGuy merged commit 4d78638 into cobbler:main Apr 19, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SchoolGuy SchoolGuy SchoolGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
libcobblersignatures
Status: Done
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.

[CLI]: Add option to load the built-in config
2 participants
@quinilo @SchoolGuy