-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#764 issue: Reword "Previously taken snapshots allow you to.." #1751
base: main
Are you sure you want to change the base?
#764 issue: Reword "Previously taken snapshots allow you to.." #1751
Conversation
We were not able to find or create Copr project
Unless the HTTP status code above is >= 500, please check your configuration for:
|
Sorry, wrong button.. |
@@ -233,7 +233,7 @@ | |||
gridBreakPoint='grid-lg' | |||
variant="compact" | |||
emptyCaption={_("No snapshots defined for this VM")} | |||
emptyCaptionDetail={_("Previously taken snapshots allow you to revert to an earlier state if something goes wrong")} | |||
emptyCaptionDetail={_("Snapshots are used to revert a VM to a earlier state" ")} |
Check notice
Code scanning / CodeQL
Syntax error Note
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The string needs a review by @garrett , I'm not a native speaker myself.
@@ -2068,8 +2068,7 @@ msgstr "Délku předpony je třeba vyplnit" | |||
|
|||
#: src/components/vm/snapshots/vmSnapshotsCard.jsx:236 | |||
msgid "" | |||
"Previously taken snapshots allow you to revert to an earlier state if " | |||
"something goes wrong" | |||
"Snapshots are used to revert a VM to a earlier state" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please drop all the po changes. The original string changes, so we can't keep the translations as-is. Also, translations don't work that way, they are maintained in weblate.
emptyCaptionDetail={_("Previously taken snapshots allow you to revert to an earlier state if something goes wrong")} | ||
emptyCaptionDetail={_("Snapshots are used to revert a VM to a earlier state" ")} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the duplicate "
and extra space.
Also, it is "an earlier state"
This is super weird in context: Firstly, the empty states are very repetitive and shouldn't say "for this VM" everywhere. We'll have to handle that in another PR. For Snapshots specifically, if we're even going to have sub text in the empty state, we should say something more like:
But we can probably even drop the "No existing snapshots" and just have "Create a snapshot to roll back to a previous state". WDYT? (Explanation: "defined" and "VM" are jargony; "this VM" is redundant on the context of that page, especially when there are multiple empty categories.) |
Alternatively, something closer to what you already have (at least for the second line):
|
No description provided.