Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#764 issue: Reword "Previously taken snapshots allow you to.." #1751

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lakshayletsgo
Copy link

No description provided.

Copy link

We were not able to find or create Copr project packit/cockpit-project-cockpit-machines-1751 specified in the config with the following error:

Cannot create a new Copr project (owner=packit project=cockpit-project-cockpit-machines-1751 chroots=['centos-stream-10-x86_64', 'centos-stream-9-x86_64']): Copr: 'packit/cockpit-project-cockpit-machines-1751' already exists. Copr HTTP response is 400 BAD REQUEST.

Unless the HTTP status code above is >= 500, please check your configuration for:

  1. typos in owner and project name (groups need to be prefixed with @)
  2. whether the project name doesn't contain not allowed characters (only letters, digits, underscores, dashes and dots must be used)
  3. whether the project itself exists (Packit creates projects only in its own namespace)
  4. whether Packit is allowed to build in your Copr project
  5. whether your Copr project/group is not private

@martinpitt martinpitt closed this Sep 4, 2024
@martinpitt martinpitt reopened this Sep 4, 2024
@martinpitt
Copy link
Member

Sorry, wrong button..

@@ -233,7 +233,7 @@
gridBreakPoint='grid-lg'
variant="compact"
emptyCaption={_("No snapshots defined for this VM")}
emptyCaptionDetail={_("Previously taken snapshots allow you to revert to an earlier state if something goes wrong")}
emptyCaptionDetail={_("Snapshots are used to revert a VM to a earlier state" ")}

Check notice

Code scanning / CodeQL

Syntax error Note

Error: Unterminated string constant
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The string needs a review by @garrett , I'm not a native speaker myself.

@@ -2068,8 +2068,7 @@ msgstr "Délku předpony je třeba vyplnit"

#: src/components/vm/snapshots/vmSnapshotsCard.jsx:236
msgid ""
"Previously taken snapshots allow you to revert to an earlier state if "
"something goes wrong"
"Snapshots are used to revert a VM to a earlier state"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please drop all the po changes. The original string changes, so we can't keep the translations as-is. Also, translations don't work that way, they are maintained in weblate.

emptyCaptionDetail={_("Previously taken snapshots allow you to revert to an earlier state if something goes wrong")}
emptyCaptionDetail={_("Snapshots are used to revert a VM to a earlier state" ")}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the duplicate " and extra space.

Also, it is "an earlier state"

@martinpitt martinpitt marked this pull request as draft September 4, 2024 08:23
@garrett
Copy link
Member

garrett commented Sep 4, 2024

This is super weird in context:

image

Firstly, the empty states are very repetitive and shouldn't say "for this VM" everywhere. We'll have to handle that in another PR.

For Snapshots specifically, if we're even going to have sub text in the empty state, we should say something more like:

No existing snapshots
Create a snapshot to roll back to a previous state

But we can probably even drop the "No existing snapshots" and just have "Create a snapshot to roll back to a previous state". WDYT?

(Explanation: "defined" and "VM" are jargony; "this VM" is redundant on the context of that page, especially when there are multiple empty categories.)

@garrett
Copy link
Member

garrett commented Sep 4, 2024

Alternatively, something closer to what you already have (at least for the second line):

No snapshots exist
Revert to an earlier state using snapshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants