Skip to content

Conversation

@mvollmer
Copy link
Member

@mvollmer mvollmer commented Mar 3, 2025

Demo: https://youtu.be/KpNcTKLjhR4
Story: https://issues.redhat.com/browse/COCKPIT-1318

  • consoles: Redesign #2008
  • Allow user choice of VNC via console.vv, SPICE via console.vv, and SPICE via link, somehow.
  • Update popup to talk about the choice.

@mvollmer mvollmer force-pushed the console-direct-spice branch from 5bb60df to c8db1b1 Compare March 6, 2025 12:40
@mvollmer mvollmer force-pushed the console-direct-spice branch from c8db1b1 to 7b27f43 Compare April 11, 2025 10:48
@mvollmer mvollmer mentioned this pull request Jun 18, 2025
@Venefilyn
Copy link
Member

Had a convo about buttons for launching here that is relevant to this PR:

#2008 (comment)

domainDesktopConsole({ name: vm.name, consoleDetail: { ...consoleDetail, address: connection_address() } });
if (consoleDetail.type == "spice") {
// Launch via direct link
const protocol = consoleDetail.tlsPort ? "spice+tls" : "spice";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This added line is not executed by any test. Details

@mvollmer
Copy link
Member Author

mvollmer commented Oct 20, 2025

Here are some design thoughts:

  • We can use a "split menu button" to let the user chose the action in a dropdown that the main button will then perform.
  • Instead of making the dropdown modify what the main button does, the dropdown items can do the action immediately.

I don't know what the "best pattern" here is. In our case, we don't have a clear primary action and a set of secondary actions. It's purely user preference which action to perform, and the user will likely do the same thing every time, so the first behavior is probably best for us.

  • We can also move the choice of action from a dropdown into the big helper popup. There we can explain the choices better with more text.

  • In any case, we should remember the choice, maybe per machine, or maybe globally.

  • Instead of omitting impossible actions (such as omitting SPICE when the VM has no SPICE), we can also always offer all options and then dynamically add whatever is missing when the user actually launches the viewer.

@mvollmer mvollmer force-pushed the console-direct-spice branch from 1768a41 to 614bc84 Compare October 20, 2025 09:15
@mvollmer mvollmer force-pushed the console-direct-spice branch from 614bc84 to 1402003 Compare October 21, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants