-
Notifications
You must be signed in to change notification settings - Fork 90
console: Launch external SPICE viewer via spice:// URL #2049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
5bb60df to
c8db1b1
Compare
c8db1b1 to
7b27f43
Compare
|
Had a convo about buttons for launching here that is relevant to this PR: |
7b27f43 to
1768a41
Compare
| domainDesktopConsole({ name: vm.name, consoleDetail: { ...consoleDetail, address: connection_address() } }); | ||
| if (consoleDetail.type == "spice") { | ||
| // Launch via direct link | ||
| const protocol = consoleDetail.tlsPort ? "spice+tls" : "spice"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This added line is not executed by any test. Details
|
Here are some design thoughts:
I don't know what the "best pattern" here is. In our case, we don't have a clear primary action and a set of secondary actions. It's purely user preference which action to perform, and the user will likely do the same thing every time, so the first behavior is probably best for us.
|
1768a41 to
614bc84
Compare
614bc84 to
1402003
Compare
Demo: https://youtu.be/KpNcTKLjhR4
Story: https://issues.redhat.com/browse/COCKPIT-1318