src: Add authorize and basic to Printer #22699
Open
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows us to use Basic authorize without base64-encoding ourselves before using the command. Signed-off-by: Freya Gustavsson <[email protected]>
Venefilyn
added
the
no-test
allisonkarlitskaya
requested changes
Dec 18, 2025
Member
allisonkarlitskaya
left a comment
allisonkarlitskaya
left a comment
There was a problem hiding this comment.
Thanks for this!
The --compact thing would be cool too!
| """Send a control message, build from **kwargs""" | ||
| self.json('', command=command, **kwargs) | ||
|
|
||
| def authorize(self, cookie: str, b64_content: str, auth_type: str = "Basic", **kwargs: Any) -> None: |
Member
There was a problem hiding this comment.
Probably make that just take the "response" as a single string instead of two strings stuck together?
Member
Author
There was a problem hiding this comment.
We can't use colon due to it being a limited character. Some parsing thing done in the main function
That's why I split it up
| encoded_response = f"{auth_type} {b64_content}" | ||
| self.json('', command="authorize", cookie=cookie, response=encoded_response, **kwargs) | ||
|
|
||
| def basic(self, cookie: str, user: str, password: str, **kwargs: Any) -> None: |
Member
There was a problem hiding this comment.
I'd also take the user:pass as a single string that the user is expected to provide their own : for. I feel less strongly about this one, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows us to use Basic authorize without base64-encoding ourselves
before using the command.
Signed-off-by: Freya Gustavsson [email protected]