kdump(arch): Add information about missing support #22713
Conversation
After finding out that the kdump-tools package is actually installed and that the problem is more Arch-related (cockpit-project#21006), I added this small notice to the view to prevent further confusion of other users.
martinpitt
left a comment
martinpitt
left a comment
There was a problem hiding this comment.
Thanks! Sorry for the delay, long xmas break. This looks good enough, and I triggered tests. I left a suggestion for improvement, if you want to push it, please rebase to current main.
| </> | ||
| ); | ||
| } | ||
| } else if (this.state.os_release.NAME?.includes('Arch')) { |
There was a problem hiding this comment.
I think an .ID == "arch" check would be more robust?
|
Let's also add a test for this. I'll fix this up. |
|
Wait, I thought about this again. This still isn't really helpful for users, we already have the "currently not supported" message, and the refered GitHub issue isn't really actionable from an upstream Cockpit point of view. I prefer to just disable kdump on Arch for the time being. I sent PR #22741 that does that, what do you think? |
|
@martinpitt I'm fine with that! We can close this PR in favour of #22741 👍 |
2 participants
After finding out that the kdump-tools package is actually installed and that the problem is more Arch-related (#21006), I added this small notice to the view to prevent further confusion of other users.
Still unsure
I'm not sure whether just checking for
Archis sufficient or if the substring should be expanded toArch Linux. The/etc/os-releasefor reference is:Screenshot