Skip to content

Conversation

@martinpitt
Copy link
Member

Commit cc7444f moved the main tarball release away from cockpit-project/action-release to gh release. But that stopped setting the steps.publish.outputs.* variables that the downstream jobs need. Compute these and put them back.


This broke both the guide and the flathub release jobs for today's 354. I tested this on my fork with release 999, and the run gets over these initial bugs. flathub fails late on a permission error, which is expected from my fork. guide fails on a build system bug, this step apparently was never tested. But after PR #22693 we'll have to change this anyway, as we'll have pre-built docs in the release tarball and don't have to rebuild them in the guide job.

Commit cc7444f moved the main tarball release away from
cockpit-project/action-release to `gh release`. But that stopped setting
the `steps.publish.outputs.*` variables that the downstream jobs need.
Compute these and put them back.
@martinpitt martinpitt added the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Jan 7, 2026
@martinpitt martinpitt requested a review from tomasmatus January 7, 2026 15:10
@martinpitt martinpitt added the .github-changes Set by a reviewer just before landing to acknowledge that a PR changes github workflows label Jan 7, 2026
Copy link
Member

@tomasmatus tomasmatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for missing this step

@martinpitt martinpitt merged commit 0929533 into cockpit-project:main Jan 7, 2026
23 of 36 checks passed
@martinpitt martinpitt deleted the release-outputs branch January 7, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

.github-changes Set by a reviewer just before landing to acknowledge that a PR changes github workflows no-test For doc/workflow changes, or experiments which don't need a full CI run,

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants