Debian, test, and other little fixes #22747
Open
+39
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spotted by lintian's systemd-service-file-missing-documentation-key check.
Conflics should be unversioned. Fixes lintian I: cockpit-ws: conflicts-with-version cockpit-tests (<< 331)
This was referenced Jan 9, 2026
Venefilyn
previously approved these changes
Jan 9, 2026
Comment on lines
+223
to
+227
| for section in 1 5 8; do | ||
| for manpage in %{manbundledir}/*.${section}; do | ||
| install -D -p -m 644 "$manpage" %{buildroot}%{_mandir}/man${section}/$(basename "$manpage") | ||
| done | ||
| done |
Member
Author
|
Eww.. older Debian/Ubuntu releases don't know watch standard 5 yet:
will fix. |
Done automatically with `uscan --update-watchfile`. Fixes lintian "older-debian-watch-file-standard 4" info. lintian < 2.127.0 does not recognize this yet, so we have to ignore its complaint on older Debian/Ubuntu releases.
/tmp/ is a tmpfs on Debian now, and lintian now started running into ENOSPC. Use /var/tmp instead.
Avoid the repetition of file names.
Commit d26b5d8 added support for the socket activated polkit helper in polkit 127. Ensure that on a "new" OS (debian-testing for now) we actually use that code path. Conversely, check that on an "old" OS (RHEL 10) the helper is still setuid root and there is no socket. This will remind us in the distant past to remove the bridge code path for executing the helper directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grab-bag from various stuff like #22693 (review) (@Venefilyn), #22726 (review) (@allisonkarlitskaya ), and Debian lintian.