Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPS: bump across etcd-io/raft#81 and disable conf change validation #106515

Merged
merged 2 commits into from
Jul 17, 2023
Merged

DEPS: bump across etcd-io/raft#81 and disable conf change validation #106515

merged 2 commits into from
Jul 17, 2023

Commits on Jul 17, 2023

  1. DEPS: bump raft 

    Picks up

- etcd-io/raft#77
- etcd-io/raft#79 (essentially an off-by-default for 77)
- etcd-io/raft#82
- etcd-io/raft#81 (needed for cockroachdb#105797)

Epic: none
Release note: None
    @tbg
    tbg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    404188d View commit details
    Browse the repository at this point in the history

  2. kvserver: prevent etcd-io/raft from dropping conf changes 

    Relies on etcd-io/raft#81.

We don't want it to, since that causes issues due to false positives. We are
taking responsibility for carrying out only valid conf changes, as we always
have.

See also etcd-io/raft#80.

Fixes cockroachdb#105797.
Epic: CRDB-25287
Release note (bug fix): under rare circumstances, a replication change could get
stuck when proposed near lease/leadership changes (and likely under overload),
and the replica circuit breakers could trip. This problem has been addressed.
Note to editors: this time it's really addressed (fingers crossed); a previous
attempt with an identical release note had to be reverted.
    @tbg
    tbg committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    4585dde View commit details
    Browse the repository at this point in the history