Skip to content

workflow: check PR base branch #148541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rail
Copy link
Member

@rail rail commented Jun 18, 2025

Bors should not be used for pull requests that do not target the master branch. Previously, bors didn't allow PRs with the backport label to be merged, but this was not restrictive enough - one can remove the label and use bors. Now, we check the base branch of the pull request to ensure it is targeting the master branch.

Release note: none
Epic: none

@rail rail self-assigned this Jun 18, 2025
@rail rail requested a review from a team as a code owner June 18, 2025 23:28
@rail rail added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf A-ci Continuous Integration backport-all Flags PRs that need to be backported to all supported release branches labels Jun 18, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Bors should not be used for pull requests that do not target the master
branch. Previously, bors didn't allow PRs with the `backport` label to be
merged, but this was not restrictive enough - one can remove the label
and use bors. Now, we check the base branch of the pull request to
ensure it is targeting the master branch.

Release note: none
Epic: none
@rail rail force-pushed the rail/pr-vrvzpknyzlym branch from 04fd0c3 to c001a34 Compare June 18, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Continuous Integration backport-all Flags PRs that need to be backported to all supported release branches C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-dev-inf
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants