build: add crdb_bench flag #149517
Open
build: add crdb_bench flag #149517
+80
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change (cockroachdb#148576) causes some test initializations to throw a panic if the binary was not build with `crdb_test`. ``` ./dev bench pkg/sql/catalog/lease -f=BenchmarkAcquireLeaseConcurrent $ bazel test pkg/sql/catalog/lease:all --nocache_test_results --test_arg -test.run=- --test_arg -test.bench=BenchmarkAcquireLeaseConcurrent --test_sharding_strategy=disabled --test_arg -test.cpu --test_arg 1 --test_arg -test.benchmem --crdb_test_off --test_env COCKROACH_TEST_FIXTURES_DIR=/Users/herko/Library/Caches/crdb-test-fixtures --sandbox_writable_path=/Users/herko/Library/Caches/crdb-test-fixtures --test_output streamed panic: Testing override for schema_locked used in non-test binary. goroutine 1 [running]: github.com/cockroachdb/cockroach/pkg/sql.TestForceDisableCreateTableWithSchemaLocked(...) pkg/sql/exec_util.go:773 github.com/cockroachdb/cockroach/pkg/sql/catalog/lease_test.TestMain(0x1400132e620?) pkg/sql/catalog/lease/main_test.go:29 +0xcc main.main() ``` This is problematic for benchmarks, which are not built with `crdb_test`. Benchmarks are not built with the `crdb_test` flag, because this flag enables metamorphic variables and extra assertions which could interfere with performance testing. This change adds a new `crdb_bench` flag, which is disabled by default. The assertions added in cockroachdb#148576 is now also skipped when `crdb_bench` is enabled. Informs: cockroachdb#148576 Fixes: cockroachdb#149339 Epic: None Release note: None
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=95b789b1d594ac6b74f377aa7555d8d98d63240d&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
herkolategan
force-pushed
the
hbl/roachprod-microbench-crdb-test
branch
from
a9bc036 to
16ba762
Compare
Set the `crdb_bench` flag to `true` when running `dev bench`. Epic: None Release note: None
Allow testing override for schema_locked for benchmark builds. Epic: None Release note: None
Epic: None Release note: None
herkolategan
force-pushed
the
hbl/roachprod-microbench-crdb-test
branch
from
16ba762 to
a477a2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change (#148576) causes some test initializations to throw a panic if
the binary was not built with
crdb_test.This is problematic for benchmarks, which are not built with
crdb_test.Benchmarks are not built with the
crdb_testflag, because this flag enablesmetamorphic variables and extra assertions which could interfere with
performance testing.
This change adds a new
crdb_benchflag, which is disabled by default. Theassertions added in #148576 are now also skipped when
crdb_benchis enabled.Informs: #148576
Fixes: #149339
Epic: None
Release note: None