backup: ignore indexes from 25.4 backups#164301
Open
kev-cao wants to merge 1 commit intocockroachdb:masterfrom
Open
backup: ignore indexes from 25.4 backups#164301kev-cao wants to merge 1 commit intocockroachdb:masterfrom
kev-cao wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Contributor
|
Merging to
|
Member
|
This change is |
kev-cao
force-pushed
the
backup/25-4-index-ignore
branch
from
379decf to
6e768e9
Compare
This commit teaches `IndexExists` to ignore backups that were taken prior to 26.1, covering the edge case outlined in cockroachdb#164114. Fixes: cockroachdb#164114 Release note (bug fix): Fixed a bug where backups taken after a 25.4 mixed version cluster downgrade could result in inconsistent backup indexes.
kev-cao
force-pushed
the
backup/25-4-index-ignore
branch
from
6e768e9 to
c37f6b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit teaches
IndexExiststo ignore backups that were taken prior to 26.1, covering the edge case outlined in #164114.Fixes: #164114
Release note (bug fix): Fixed a bug where backups taken after a 25.4 mixed version cluster downgrade could result in inconsistent backup indexes.