changefeedccl: add regression test for schema_locked backfill skipping#164302
Draft
rharding6373 wants to merge 1 commit intocockroachdb:masterfrom
Draft
changefeedccl: add regression test for schema_locked backfill skipping#164302rharding6373 wants to merge 1 commit intocockroachdb:masterfrom
rharding6373 wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Add TestChangefeedSchemaLockedBackfill with 7 subtests that exercise schema changes on tables with schema_locked=true while a changefeed is running. The test validates that the SchemaFeed correctly detects all schema change events even when schema_locked optimization pauses descriptor polling. Subtests: 1. families: column families with schema_locked, drop + add columns 2. no-families: same without column families 3. sequential-changes: four sequential schema changes (drop, add, add, drop) 4. computed-stored: ADD COLUMN ... AS ... STORED on schema_locked table 5. alter-primary-key: ALTER PRIMARY KEY, verify new key encoding works 6. truncate: TRUNCATE on schema_locked table, verify error is produced 7. multi-table: two schema_locked tables with interleaved schema changes These tests target bugs like cockroachdb#149861 where the declarative schema changer atomically toggles schema_locked alongside a column mutation, and the SchemaFeed's pauseOrResumePolling could advance the frontier past the mutation version, causing a backfill to be silently skipped. Informs: cockroachdb#149861, cockroachdb#148963 Epic: none Release note: None Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Merging to
|
Member
|
This change is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add TestChangefeedSchemaLockedBackfill with 7 subtests that exercise schema changes on tables with schema_locked=true while a changefeed is running. The test validates that the SchemaFeed correctly detects all schema change events even when schema_locked optimization pauses descriptor polling.
Subtests:
These tests target bugs like #149861 where the declarative schema changer atomically toggles schema_locked alongside a column mutation, and the SchemaFeed's pauseOrResumePolling could advance the frontier past the mutation version, causing a backfill to be silently skipped.
Informs: #149861, #148963
Epic: none
Release note: None