Optionally expose node locality (region, zone, host) to pod #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottcrossen
changed the title
scottcrossen
force-pushed
the
scottcrossen/node-locality
branch
3 times, most recently
from
2dd218d
to
391d5b6
Compare
scottcrossen
force-pushed
the
scottcrossen/node-locality
branch
from
391d5b6
to
c27da88
Compare
|
Rebased |
scottcrossen
force-pushed
the
scottcrossen/node-locality
branch
from
c27da88
to
b9946d2
Compare
scottcrossen
force-pushed
the
scottcrossen/node-locality
branch
from
b9946d2
to
f6ca266
Compare
|
Rebased |
cockroachdb/templates/job.init.yaml
Outdated
| @@ -16,9 +16,9 @@ metadata: | |||
| {{- with .Values.labels }} | |||
| {{- toYaml . | nindent 4 }} | |||
| {{- end }} | |||
| annotations: | |||
There was a problem hiding this comment.
I don't like this approach, helm hooks annotations should always be present or someone who wants to add new annotations will override helms one
There was a problem hiding this comment.
You can add something like extraJobAnnotations and list them after helm hooks
There was a problem hiding this comment.
Hi! The purpose of this was to make it possible to remove the annotations.
I've moved this discussion into a new PR: #206
scottcrossen
force-pushed
the
scottcrossen/node-locality
branch
from
f6ca266
to
3c92778
Compare
|
Rebased PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion: Has this been investigated before? I imagine that most people want these locality tags in multi-region setups. This PR adds them from well-known node labels. I'm happy to transfer ownership of my proof-of-concept
initContainerthat mounts the node labels in the statefulset.TLDR: This pullrequest automatically adds the CLI start flag values