Add extraPodSpec to statefulset and init job #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c fields to be added to the pods
|
Can you please add some tests for this feature and then we can take a look a it. The workflow you are trying to support is using vault to generate the certs instead of CRDBs self-signed version? |
Yes, in general that's what I'm trying to support. Though, since I've made this PR, there are other fields I need to add to set cockroach up to not use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows adding arbitrary values to the statefulset's pod spec. (As well as the init job.) This is needed to allow setting
shareProcessNamespace: trueto the pod spec to accommodate Hashicorp Vault injected dynamic certificates.