Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sort storage params for stable helm upgrade #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

sort storage params for stable helm upgrade #91

wants to merge 1 commit into from

Conversation

EladDolev
Copy link
Contributor

subsequent helm upgrade may fail because the StatefulSet allows only handful of changes, and "cockroachdb.conf.store" function may return different output every time

@EladDolev
Copy link
Contributor Author

any chance somebody can review this ?
this thing causes random pod restart on every helm apply...

@udnay udnay added the triage/accepted Indicate an issue and PR is ready to be actively worked on label Oct 18, 2021
@sergeyshaykhullin
Copy link
Contributor

Seems valid, but i use store config half a year and upgrade never failed

@EladDolev
Copy link
Contributor Author

Upgrade should not fail, but may cause unnecessary pods restart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
triage/accepted Indicate an issue and PR is ready to be actively worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EladDolev @sergeyshaykhullin @udnay