sort storage params for stable helm upgrade#91
Open
EladDolev wants to merge 1 commit intocockroachdb:masterfrom
Open
sort storage params for stable helm upgrade#91EladDolev wants to merge 1 commit intocockroachdb:masterfrom
EladDolev wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Contributor
Author
|
any chance somebody can review this ? |
Contributor
|
Seems valid, but i use store config half a year and upgrade never failed |
Contributor
Author
|
Upgrade should not fail, but may cause unnecessary pods restart |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
subsequent
helm upgrademay fail because the StatefulSet allows only handful of changes, and "cockroachdb.conf.store" function may return different output every time