db: avoid keyspanimpl.TableNewSpanIter closure allocation#3584
Closed
jbowens wants to merge 1 commit intocockroachdb:masterfrom
Closed
db: avoid keyspanimpl.TableNewSpanIter closure allocation#3584jbowens wants to merge 1 commit intocockroachdb:masterfrom
jbowens wants to merge 1 commit intocockroachdb:masterfrom
Conversation
The tableNewIters func requires a context, but the keyspanimpl.TableNewSpanIter func used by keyspan.LevelIter did not take one. This required iterator construction to close over the context and the tableNewIters to create an keyspanimpl.TableNewSpanIter, forcing an allocation. This commit refactors the keyspanimpl.LevelIter to embed a context, like the point iterator's levelIter, and propagate the context into TableNewSpanIter through an argument.
Member
|
This change is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tableNewIters func requires a context, but the keyspanimpl.TableNewSpanIter func used by keyspan.LevelIter did not take one. This required iterator construction to close over the context and the tableNewIters to create an keyspanimpl.TableNewSpanIter, forcing an allocation.
This commit refactors the keyspanimpl.LevelIter to embed a context, like the point iterator's levelIter, and propagate the context into TableNewSpanIter through an argument.