Skip to content

github: rework nightly workflows and run on crl-release-25.2 #4529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

RaduBerinde
Copy link
Member

@RaduBerinde RaduBerinde commented Apr 10, 2025

This change reworks the nightly workflows so they can be run on any
branch. We now have top-level workflows for master and
crl-release-25.2 which call all the nightly workflows (instead of
having each one get scheduled separately).

@RaduBerinde RaduBerinde requested a review from a team as a code owner April 10, 2025 23:42
@RaduBerinde RaduBerinde requested a review from xxmplus April 10, 2025 23:42
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@RaduBerinde RaduBerinde force-pushed the nightly-run-on-25.2 branch from 090a690 to 503e4e4 Compare April 10, 2025 23:43
Copy link
Collaborator

@jbowens jbowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 8 of 10 files at r1, all commit messages.
Reviewable status: 8 of 10 files reviewed, all discussions resolved (waiting on @xxmplus)

@RaduBerinde RaduBerinde marked this pull request as draft April 11, 2025 14:55
@RaduBerinde
Copy link
Member Author

I need to rework this so the go versions we test with can be different depending on the branch.

This change reworks the nightly workflows so they can be run on any
branch. We now have top-level workflows for `master` and
`crl-release-25.2` which call all the nightly workflows (instead of
having each one get scheduled separately).
@RaduBerinde RaduBerinde force-pushed the nightly-run-on-25.2 branch from 503e4e4 to 6b1af31 Compare April 12, 2025 04:16
@RaduBerinde RaduBerinde marked this pull request as ready for review April 12, 2025 04:19
@RaduBerinde
Copy link
Member Author

Done.

@RaduBerinde RaduBerinde merged commit 1fec080 into cockroachdb:master Apr 14, 2025
5 checks passed
@RaduBerinde RaduBerinde deleted the nightly-run-on-25.2 branch April 14, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants