manifest: avoid BlobReferences interface allocation #4678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a microbenchmark that exercises a point lookup wihtin a database with separated values. Informs cockroachdb#112.
The manifest.BlobReferences type is used to satisfy the sstable.BlobReferences
interface. Previously the interface was implemented on the slice receiver type.
This caused an allocation whenever we used this type to satisfy the
sstable.BlobReferences interface. This commit moves the implementation onto the
pointer type, avoiding the need to heap-allocate a copy of the slice header.
```
goos: darwin
goarch: arm64
pkg: github.com/cockroachdb/pebble
cpu: Apple M1 Pro
│ before.txt │ after.txt │
│ sec/op │ sec/op vs base │
PointLookupSeparatedValues/keys=1m,valueLen=100-10 1.636µ ± 8% 1.585µ ± 2% -3.09% (p=0.001 n=10)
PointLookupSeparatedValues/keys=1m,valueLen=1024-10 2.452µ ± 4% 2.373µ ± 4% -3.22% (p=0.007 n=10+6)
geomean 2.003µ 1.939µ -3.15%
│ before.txt │ after.txt │
│ B/op │ B/op vs base │
PointLookupSeparatedValues/keys=1m,valueLen=100-10 32.000 ± 0% 8.000 ± 0% -75.00% (p=0.000 n=10)
PointLookupSeparatedValues/keys=1m,valueLen=1024-10 265.5 ± 7% 210.0 ± 22% -20.90% (p=0.001 n=10+6)
geomean 92.17 40.99 -55.53%
│ before.txt │ after.txt │
│ allocs/op │ allocs/op vs base │
PointLookupSeparatedValues/keys=1m,valueLen=100-10 1.000 ± 0% 0.000 ± 0% -100.00% (p=0.000 n=10)
PointLookupSeparatedValues/keys=1m,valueLen=1024-10 1.000 ± 0% 0.000 ± 0% -100.00% (n=10+6)
geomean 1.000 ? ¹ ²
¹ summaries must be >0 to compute geomean
² ratios must be >0 to compute geomean
```
Fix cockroachdb#4668.
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
db: add BenchmarkPointLookupSeparatedValues
Add a microbenchmark that exercises a point lookup wihtin a database with
separated values.
Informs #112.
manifest: avoid BlobReferences interface allocation
The manifest.BlobReferences type is used to satisfy the sstable.BlobReferences
interface. Previously the interface was implemented on the slice receiver type.
This caused an allocation whenever we used this type to satisfy the
sstable.BlobReferences interface. This commit moves the implementation onto the
pointer type, avoiding the need to heap-allocate a copy of the slice header.
Fix #4668.