db: fix iterator leak on close#5854
Merged
RaduBerinde merged 1 commit intocockroachdb:masterfrom Mar 23, 2026
Merged
Conversation
This change fixes an iterator leak in the table stats code. This leak was exposed by cockroachdb#5813 which plumbed a context that gets canceled on close. If the cancelation happens right as we're opening the range key iterator, we leak the range del iterator. Fixes cockroachdb#5843
Member
|
This change is |
sumeerbhola
approved these changes
Mar 23, 2026
Collaborator
sumeerbhola
left a comment
sumeerbhola
left a comment
There was a problem hiding this comment.
@sumeerbhola reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on RaduBerinde).
Member
Author
|
TFTR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes an iterator leak in the table stats code. This leak
was exposed by #5813 which plumbed a context that gets canceled on
close. If the cancelation happens right as we're opening the range key
iterator, we leak the range del iterator.
Fixes #5843