Open
Conversation
Code Size Check Report
Interface Check Report! WARNING this pull request has changed these public interfaces:
@@ -70279,9 +70279,14 @@
}
export class _cocos_particle_2d_particle_simulator_2d__Particle {
pos: math.Vec2;
startPos: math.Vec2;
- color: math.Color;
+ color: {
+ r: number;
+ g: number;
+ b: number;
+ a: number;
+ };
deltaColor: {
r: number;
g: number;
b: number;
|
zhefengzhang
commented
Sep 24, 2025
| public pos = new Vec2(0, 0); | ||
| public startPos = new Vec2(0, 0); | ||
| public color = new Color(0, 0, 0, 255); | ||
| public color = { r: 0, g: 0, b: 0, a: 255 }; |
Contributor
Author
There was a problem hiding this comment.
因为 Color 类型对象使用 Uint8ClampedArray 类型数组存储 rgba 数值,此类型数组的元素值添加时会对数值进行四舍五入。
而在 particle-simulator-2d.ts 中计算每帧粒子的颜色数据需要 rgba 值与 dt 浮点值相乘,最终得到的 rgba 浮点值赋值给 color 的 rgba 值时会被四舍五入,导致最终显示结果不符合预期。
Because Color type objects use an array of type Uint8ClampedArray to store rgba values, element values of this array type are rounded when added.
However, calculating the color data of each frame particle in particle-simulator-2d.ts requires multiplying the rgba value by the dt floating point value. The resulting rgba floating point value assigned to the rgba value of color will be rounded, resulting in the final display result not meeting expectations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: https://github.com/cocos/3d-tasks/issues/19132