Updated get_recipes so that we can return more than 10 recipes when the page indicator is not present #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from_page bug: updated get_recipes so that we can return more than 10 recipes when the page indicator is not present.
…hen the page indicator is not present, and to get any recipes found on pages not indicated by the pagination links (i.e. 3 pgs exist, but there is only 1 pagination links)
|
I don't personally use the Recipes feature of MyFitnessPal, so I'm not sure I can test this directly. I wonder if somebody in the community who either uses Recipes (or has the time to start using it) can have a look at this PR and confirm with me that it works before I merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: refactored get_recipes on client.py and added _get_recipes_from_page
bug: updated get_recipes so that we can return more than 10 recipes when the page indicator is not present.
Refer to #180