Skip to content

Update/dim curriculum survey responses #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 29, 2025

Conversation

nataliazm99
Copy link
Collaborator

Updates to curriculum survey models:

  1. Remove 'lower()' from contained_levels to pass through the question text as displayed to students
  2. Include the number of possible answers in to allow for calculating a percent
  3. Fix the logic for answer texts which was leaving out questions with types other than Free Response and Multi Select
  4. Include three new fields to dim_curriculum_survey_responses:
    i. num_response_options: number of possible answers in to allow for calculating a percent
    ii. user_level_id: to allow counting unique submissions
    iii. ul.level_source_id : to allow joining to level_sources when needed

Change log
Natalia 4/11/2025

@nataliazm99 nataliazm99 requested a review from coryamanda April 11, 2025 13:52
@nataliazm99 nataliazm99 marked this pull request as draft April 11, 2025 13:52
Removing the select distinct
@nataliazm99 nataliazm99 marked this pull request as ready for review April 11, 2025 13:56
Copy link
Collaborator

@coryamanda coryamanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this took a while to review, I needed to refresh myself on the logic of level_sources. Looks good to me!

@nataliazm99 nataliazm99 merged commit f918e6c into main Apr 29, 2025
1 check was pending
@nataliazm99 nataliazm99 deleted the update/dim_curriculum_survey_responses branch April 29, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants