Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-typescript): add TS core logic #932

Merged
merged 13 commits into from
Feb 14, 2025
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/plugin-typescript/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
},
"type": "module",
"dependencies": {
"@code-pushup/models": "0.58.0",
"@code-pushup/utils": "0.58.0"
"@code-pushup/models": "*",
"@code-pushup/utils": "*"
},
"peerDependencies": {
"typescript": ">=4.0.0"
Expand Down
3 changes: 1 addition & 2 deletions packages/plugin-typescript/src/lib/runner/runner.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
expectedAudits: { slug: AuditSlug }[];
};

export function createRunnerFunction(options: RunnerOptions): RunnerFunction {

Check warning on line 19 in packages/plugin-typescript/src/lib/runner/runner.ts

View workflow job for this annotation

GitHub Actions / Code PushUp

<✓> JSDoc coverage | Functions coverage

Missing functions documentation for createRunnerFunction
const { tsconfig, expectedAudits } = options;
return async (): Promise<AuditOutputs> => {
const diagnostics = await getTypeScriptDiagnostics({ tsconfig });
Expand All @@ -24,8 +24,7 @@
Partial<Record<CodeRangeName, Pick<AuditOutput, 'slug' | 'details'>>>
>((acc, diag) => {
const slug = tsCodeToAuditSlug(diag.code);
const existingIssues: Issue[] =
(acc[slug] && acc[slug].details?.issues) || ([] as Issue[]);
const existingIssues: Issue[] = acc[slug]?.details?.issues ?? [];
return {
...acc,
[slug]: {
Expand All @@ -43,9 +42,9 @@
const issues = details?.issues ?? [];
return {
slug,
score: issues.length === 0 ? 1 : 0,

Check failure on line 45 in packages/plugin-typescript/src/lib/runner/runner.ts

View workflow job for this annotation

GitHub Actions / Code PushUp

<✓> Code coverage | Branch coverage

1st branch is not taken in any test case.
value: issues.length,
...(issues.length > 0 ? { details } : {}),

Check failure on line 47 in packages/plugin-typescript/src/lib/runner/runner.ts

View workflow job for this annotation

GitHub Actions / Code PushUp

<✓> Code coverage | Branch coverage

1st branch is not taken in any test case.
} satisfies AuditOutput;
});
};
Expand Down
Loading