-
Notifications
You must be signed in to change notification settings - Fork 993
fix(sisyphus-orchestrator): preserve subagent response in output transformation #698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
fix(sisyphus-orchestrator): preserve subagent response in output transformation #698
Conversation
|
All contributors have signed the CLA. Thank you! ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
|
recheck |
Gladdonilli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Clean fix for an important usability issue.
What this fixes: Previously, the orchestrator was discarding the actual subagent response and replacing it with just git diff stats. This made debugging failed/incomplete tasks nearly impossible since the orchestrator only saw file changes, not what the subagent reported.
The fix: Captures the original response before transformation and includes it in the output. Simple, focused, no side effects.
Approved.
Problem
When
sisyphus_taskcompletes in boulder/orchestrator mode, thetool.execute.afterhook replaces the entire subagent response with git diff stats. This causes issues when:The orchestrator sees identical output each time (just git stats), making it appear the subagent is "stuck in a loop" when in reality the response is being discarded.
Solution
Preserve the original subagent response by storing it before transformation and including it in the output:
Testing
Summary by cubic
Preserves the original subagent response in Sisyphus orchestrator output instead of replacing it with git diff stats. This fixes confusing “loop” outputs and improves debugging and resume flows.
Written for commit aa44c54. Summary will update on new commits.