Fix generic_type assignment in shared.data_type.rb #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dario Pranjic <[email protected]>
raphael-goetz
approved these changes
Dec 5, 2025
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the DataTypeIdentifier#from_hash method where the entire config hash was incorrectly being passed to GenericType.from_hash instead of extracting the nested :generic_type value first.
Key Changes:
- Corrects the
generic_typeassignment to extractconfig[:generic_type]before passing toGenericType.from_hash, making it consistent with how other nested types are handled throughout the codebase.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.