Skip to content

fix loading error in /discord/redirect #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

manishpali17
Copy link
Contributor

@manishpali17 manishpali17 commented May 22, 2024

PR Fixes:

  • FIx loading error when user cancels access to Discord

Resolves #692
Resolves #720

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

@AyushShivhare79
Copy link
Contributor

He just copied the exact code of mine and even the certificate png is copied @hkirat
This is my PR #728

@hkirat hkirat closed this May 30, 2024
@manishpali17
Copy link
Contributor Author

manishpali17 commented May 30, 2024

Hi @AyushShivhare79,

why are you whining like a child? I made a mistake by not checking the PR request first, but here is the conversation with ChatGPT.

chatgpt

I didn't copy your code; I just asked ChatGPT for help, and it gave me the same response. It's not my fault. I can even say that you copied your code from ChatGPT because it gave me the exact solution, lol.

After this, I also checked to see if the code was working correctly, and I found the UI was out of place, so I made changes to the UI as well.
it looked like this.
before

after change
certificateui

@AyushShivhare79
Copy link
Contributor

@manishpali17 ChatGPT can't align the text to right position in image are you able to run the test case locally ser? The Png text size almost same as mine. Although The PR was already raised.

@manishpali17
Copy link
Contributor Author

manishpali17 commented May 30, 2024

@AyushShivhare79, bro, if I had seen your comment on my PR, I would have closed it myself. I don't like to take credit for your work.

And here it is now. You can see that I used ChatGPT 4.0, which also takes images. It gave me the exact code. I can't share the conversation due to some error, but here is the screenshot. I used the original image, so the size is the same.

chat

I don't want to continue this conversation anymore

@Smnthjm08
Copy link
Contributor

@AyushShivhare79
Copy link
Contributor

AyushShivhare79 commented May 30, 2024

@Smnthjm08 What ser?

@Smnthjm08
Copy link
Contributor

Smnthjm08 commented May 30, 2024

@Smnthjm08 What ser?

I tried to do the changes. But I couldn't test the certificate. Can I know how to do that
ps: I'm a beginner to OS

@AyushShivhare79
Copy link
Contributor

@Smnthjm08 You can connect me on discord i got you on OSS-chat I will teach you how to generate certificate for local test user or any user for testing but this issue is already resolved so IG you should work on something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: certificate typo bug: discord error when user denied Oauth process ( show loding )
4 participants