-
-
Notifications
You must be signed in to change notification settings - Fork 199
Refactor invites #2290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Refactor invites #2290
Conversation
I don't think everyone has to use it - but I will, and it's helpful for me. I don't think it'll impact anyone else on the project, will it?
…On 19 August 2025 20:19:04 BST, Till! ***@***.***> wrote:
@till commented on this pull request.
> @@ -0,0 +1,11 @@
+repos:
Kinda a no no for me. Would defer to CI for that. 🫣
--
Reply to this email directly or view it on GitHub:
#2290 (review)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
I looked, and I learned. cc @till
Note the difference in file location: |
a5b21fa
to
cfdacae
Compare
I've updated the commit message to reflect the fact that it's optional |
Thank you, but I already knew. If we are looking to get to a standard (= how ruby code looks) then I am happy to build a CI job that can run but doesn't fail the build but gives feedback. Then we can gradually enable rules that may make sense etc.. If this is meant for only one person, then I am not sure that it needs to be checked in. Whatever is checked in becomes status quo usually. |
I'll break this apart. It's clear that the use of pre-commit is more contentious than I anticipated and needs to be discussed somewhere else, but I don't want it blocking the feature development |
602431d
to
31320bb
Compare
14df878
to
edb4e3b
Compare
This moves the 'attendance management' concerns into a separate object. Having it as a separate object will allow me to update things from elsewhere. While doing so I've also made a small method to tidy up a long casting. Signed-off-by: jonathan.kerr <[email protected]>
edb4e3b
to
b95fcaa
Compare
This refactors out a Controller method to a plain ruby object. I'm doing this so that I can access it from other Controllers where we need to update attendance at a Workshop.
It may be that in the future the entire Controller can be removed, but for now I want to make small changes that don't break anything that's already deployed.