chore: remove unused i18n feature #2319
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The files were added in _ codebar#647 - codebar#813 But has not been put to use. Once we're at Rails 8, we can re-visit if we want to implement localisation. I'm sure things have moved forwards since this was introduced in 2018.
|
We can always dig this out of the git history again, if we need it. |
|
@mroderick is this getting in the way of the upgrade to Rails v8? Why are we trying to remove it? These were definitely used for a while, I forgot now in what context (e.g. which chapter used it but there was efforts to translate the site to Spanish and German for sure). @KimberleyCook what do you think? I say instead of deleting it we need to focus on improving it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The files were added in
But has not been put to use.
Once we're at Rails 8, we can re-visit if we want to implement
localisation. I'm sure things have moved forwards since this was
introduced in 2018.