fix: add codecov args #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #248 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 4 4
=========================================
Hits 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
thomasrockhu-codecov
force-pushed
the
th/add-codecov-args
branch
7 times, most recently
from
0937b64 to
48256a0
Compare
thomasrockhu-codecov
force-pushed
the
th/add-codecov-args
branch
from
48256a0 to
48a6055
Compare
spalmurray
reviewed
May 23, 2025
spalmurray
reviewed
May 23, 2025
|
|
||
| if len(contents) >= 8191: | ||
| print(f'Due to Windows limitations, script {new_file} must be less than 8192 chars') | ||
| exit(1) |
There was a problem hiding this comment.
Is it not possible to have non-windows runners? Can we remove this condition for those folks if so?
There was a problem hiding this comment.
I think the effort to add in the checking for non-windows and building two versions of the orb don't seem worth it. Although, tbf, this is kinda... muckity muck anyways
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #246