Skip to content

fix: handle failure to convert u64 to usize #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025

Conversation

joseph-sentry
Copy link
Contributor

we can handle this (unlikely) failure gracefully and just not show the line number or col in the context we pass back

we can handle this (unlikely) failure gracefully and just not show
the line number or col in the context we pass back
Copy link

codecov bot commented May 5, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.90%. Comparing base (45a671a) to head (81693b7).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/raw_upload.rs 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
- Coverage   96.95%   96.90%   -0.05%     
==========================================
  Files          15       15              
  Lines        1902     1905       +3     
==========================================
+ Hits         1844     1846       +2     
- Misses         58       59       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented May 5, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/raw_upload.rs 88.88% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link

codspeed-hq bot commented May 5, 2025

CodSpeed Performance Report

Merging #78 will not alter performance

Comparing joseph/with-context (81693b7) with main (45a671a)

Summary

✅ 6 untouched benchmarks

@joseph-sentry joseph-sentry requested a review from Swatinem May 5, 2025 14:03
@joseph-sentry joseph-sentry merged commit 638742b into main May 5, 2025
8 of 12 checks passed
@joseph-sentry joseph-sentry deleted the joseph/with-context branch May 5, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants