feat: return warnings in parsing info

[joseph-sentry]

we want to be able to return warnings when parsing a file, this is for cases where we want to let the user know something's wrong but continue parsing the rest of the JUnit XML because it may be partially valid

this is being implemented because I realized that failing to parse the entire file because one test case might have a really long name is not ideal for users, but we shouldn't silently skip including that test case either, we still want to let them know that something's in their JUnit XML isn't being parsed

this commit also includes changes to the attribute parsing so we can error when we fail to parse attributes, and return warnings when we fail to validate the attribute's value (see AttrsOrWarning)

this also means that i added logic for signalling that we're ignoring the test case we're currently parsing by making saved_testrun an enum (see TestrunOrSkipped)

I'm not sure if making warnings an Option<Vec> would be better than making it a Vec and having it be empty

also the fact that we have to pass WarningInfo objects back from the use_reader function then format it to include location info is unfortunate but it lets us avoid iterating over the buffer to get the line/col every time we want to create a warning

also the decision to include the warnings in the parsing info is to avoid breaking the interface of the parse_raw_upload function, which still returns the same tuple

[codecov-staging]

Codecov Report

Attention: Patch coverage is 85.35354% with 29 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
src/junit.rs	81.57%	28 Missing ⚠️
src/raw_upload.rs	97.67%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

[codecov]

Codecov Report

Attention: Patch coverage is 85.35354% with 29 lines in your changes missing coverage. Please review.

Project coverage is 95.78%. Comparing base (14fe3d7) to head (f129010).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
src/junit.rs	81.57%	28 Missing ⚠️
src/raw_upload.rs	97.67%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
- Coverage   96.84%   95.78%   -1.07%     
==========================================
  Files          16       17       +1     
  Lines        1934     2038     +104     
==========================================
+ Hits         1873     1952      +79     
- Misses         61       86      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[codspeed-hq]

CodSpeed Performance Report

Merging #79 will not alter performance

_{Comparing joseph/warnings (f129010) with main (14fe3d7)}

Summary

✅ 6 untouched benchmarks

[giovanni-guidini]

instead of having an enum for this, have we considered creating a specific Err type for "we're missing some info" and matching the error returned from the Result to that error type so we know some info is missing?

The caller of parse_testcase_attrs can infer if parsing attributes failed with a "recuperable" error. Would let you keep the nice interface of RelevantAttrs and maybe simplify the code a little bit

[Swatinem]

I agree, that would make things here a bit cleaner.

[giovanni-guidini]

is this location the byte inside the file? (just curious)

[giovanni-guidini]

😂😂😂 great test. Seems true.

[thomasrockhu-codecov]

lolol, glad you pointed this out

[Swatinem]

I think there might be things to improve here, but also I don’t want to block this for too long. So its fine to land as-is, and improve it later.

[Swatinem]

I would actually call this errors

[Swatinem]

I agree, that would make things here a bit cleaner.