Skip to content

fix: from py obj impl for framework and outcome #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

joseph-sentry
Copy link
Contributor

No description provided.

Copy link

codecov bot commented May 20, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 95.78%. Comparing base (f4f44a3) to head (3236ccf).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/testrun.rs 40.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #82   +/-   ##
=======================================
  Coverage   95.78%   95.78%           
=======================================
  Files          17       17           
  Lines        2038     2038           
=======================================
  Hits         1952     1952           
  Misses         86       86           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented May 20, 2025

CodSpeed Performance Report

Merging #82 will not alter performance

Comparing joseph/fix (3236ccf) with main (f4f44a3)

Summary

✅ 6 untouched benchmarks

@codecov-notifications
Copy link

codecov-notifications bot commented May 20, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/testrun.rs 40.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

"Pytest" => Ok(Framework::Pytest),
"Vitest" => Ok(Framework::Vitest),
"Jest" => Ok(Framework::Jest),
"PHPUnit" => Ok(Framework::PHPUnit),
_ => Err(PyErr::new::<pyo3::exceptions::PyValueError, _>(format!(
"Invalid outcome: {}",
"Invalid framework: {}",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@joseph-sentry
Copy link
Contributor Author

closing for #80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants